linux-kernel - Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXtuexNdZhKvfAg6@smile.fi.intel.com>
Date: Thu, 29 Jan 2026 16:28:11 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Ramona Gradinariu <ramona.gradinariu@...log.com>,
	Andrew Ijano <andrew.ijano@...il.com>,
	Gustavo Bastos <gustavobastos@....br>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> Remove unused int2_bitmask field from adxl372_state struct.
> The field is declared but never accessed in the driver.

While patches are okay, you have two issues with the series (or three):
- the email thread is not a thread, missed --thread?
- the series lacks of a cover letter

And optional third one: should it even be a series in the first place?

You can use my script [1] to make it not forgotten.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

P.S. I hope that this simple thing can be caught during internal reviews...

-- 
With Best Regards,
Andy Shevchenko