linux-kernel - RE: [PATCH 1/3] iio: accel: adxl372: remove unused int2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY4PR03MB33996493A5C4921B8C8C3B899B9EA@CY4PR03MB3399.namprd03.prod.outlook.com>
Date: Thu, 29 Jan 2026 14:37:58 +0000
From: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael"
	<Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        David
 Lechner <dlechner@...libre.com>,
        "Sa, Nuno" <Nuno.Sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>,
        "Gradinariu, Ramona"
	<Ramona.Gradinariu@...log.com>,
        Andrew Ijano <andrew.ijano@...il.com>,
        Gustavo Bastos <gustavobastos@....br>,
        "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...el.com>
> Sent: Thursday, January 29, 2026 4:28 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@...log.com>
> Cc: Lars-Peter Clausen <lars@...afoo.de>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Jonathan Cameron <jic23@...nel.org>;
> David Lechner <dlechner@...libre.com>; Sa, Nuno <Nuno.Sa@...log.com>;
> Andy Shevchenko <andy@...nel.org>; Gradinariu, Ramona
> <Ramona.Gradinariu@...log.com>; Andrew Ijano
> <andrew.ijano@...il.com>; Gustavo Bastos <gustavobastos@....br>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field
> 
> [External]
> 
> On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> > Remove unused int2_bitmask field from adxl372_state struct.
> > The field is declared but never accessed in the driver.
> 
> While patches are okay, you have two issues with the series (or three):
> - the email thread is not a thread, missed --thread?

Thanks for pointing that out. I never used --thread before, is the first time I am 
seeing it mentioned in a review.

> - the series lacks of a cover letter

True. Will do that in v2 (if changes requested). Btw, for these small changes if they
aren't placed in a series but individually I guess I can skip the cover letter?

> You can use my script [1] to make it not forgotten.
> 
> [1]: https://urldefense.com/v3/__https://github.com/andy-shev/home-bin-
> tools/blob/master/ge2maintainer.sh__;!!A3Ni8CS0y2Y!48H-
> JjuYcJZ2OfRfcWweVwMeYt0ghmCKzi1zlIX6jeIA15T0zhb28_T2Zj1YrAL8ho-
> gPXrtsmWhbYh4wW8N1TrsINiFNkI$
> 
> P.S. I hope that this simple thing can be caught during internal reviews...
> 
> --
> With Best Regards,
> Andy Shevchenko
>