linux-kernel - Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpBq=UNLnMmW97Y0jLvu8eRwt_Y6gf3ZGkd8RBqS79yZg@mail.gmail.com>
Date: Thu, 29 Jan 2026 16:12:14 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Andre Korol <andre.korol.dev@...il.com>
Cc: zhoubinbin@...ngson.cn, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: loongson2-mmc: drop redundant memset after dma_alloc_coherent()

On Thu, 29 Jan 2026 at 04:59, Andre Korol <andre.korol.dev@...il.com> wrote:
>
> dma_alloc_coherent() returns zeroed memory, so the memset() immediately
> after allocation is redundant.
>
> Signed-off-by: Andre Korol <andre.korol.dev@...il.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/loongson2-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index da3daab5f3d6..026cbd80f114 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -846,7 +846,6 @@ static int ls2k2000_mmc_set_internal_dma(struct loongson2_mmc_host *host,
>         if (!host->sg_cpu)
>                 return -ENOMEM;
>
> -       memset(host->sg_cpu, 0, PAGE_SIZE);
>         return 0;
>  }
>
> --
> 2.51.0
>