linux-kernel - Re: [PATCH V4 17/22] dt-bindings: PCI: tegra194: Add monitor clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129164000.GA1237815-robh@kernel.org>
Date: Thu, 29 Jan 2026 10:40:00 -0600
From: Rob Herring <robh@...nel.org>
To: Manikanta Maddireddy <mmaddireddy@...dia.com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kwilczynski@...nel.org,
	mani@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	thierry.reding@...il.com, jonathanh@...dia.com,
	jingoohan1@...il.com, vidyas@...dia.com, cassel@...nel.org,
	18255117159@....com, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 17/22] dt-bindings: PCI: tegra194: Add monitor clock
 support

On Mon, Jan 26, 2026 at 01:15:14PM +0530, Manikanta Maddireddy wrote:
> From: Vidya Sagar <vidyas@...dia.com>
> 
> Tegra supports PCIe core clock monitoring for any rate changes that may be
> happening because of the link speed changes. This is useful in tracking
> any changes in the core clock that are not initiated by the software.
> 
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@...dia.com>
> ---
> V4:
> * None
> 
> V3:
> * This is a new patch in this series
> 
>  .../devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml    | 6 +++++-
>  .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml       | 6 +++++-
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> index 6d6052a2748f..ca5da919c347 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> @@ -55,12 +55,16 @@ properties:
>        - const: intr
>  
>    clocks:
> +    minItems: 1
>      items:
> -      - description: module clock
> +      - description: module's core clock
> +      - description: module's monitor clock

Drop "module's"

>  
>    clock-names:
> +    minItems: 1
>      items:
>        - const: core
> +      - const: core_m

I would use "module" unless this corresponds to h/w documentation.

Otherwise,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>