linux-kernel - Re: [v4,4/4] stmmac: s32: enable support for Multi-IRQ mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129051004.375682-1-kuba@kernel.org>
Date: Wed, 28 Jan 2026 21:10:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: jan.petrous@....nxp.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	edumazet@...gle.com,
	shawnguo@...nel.org,
	kernel@...gutronix.de,
	krzk+dt@...nel.org,
	robh@...nel.org,
	andrew+netdev@...n.ch,
	mbrugger@...e.com,
	davem@...emloft.net,
	pabeni@...hat.com,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org,
	s32@....com,
	imx@...ts.linux.dev,
	linux-stm32@...md-mailman.stormreply.com,
	s.hauer@...gutronix.de,
	conor+dt@...nel.org,
	chester62515@...il.com,
	festevam@...il.com,
	mcoquelin.stm32@...il.com,
	ghennadi.procopciuc@....nxp.com,
	devicetree@...r.kernel.org,
	alexandre.torgue@...s.st.com
Subject: Re: [v4,4/4] stmmac: s32: enable support for Multi-IRQ mode

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
stmmac: s32: enable support for Multi-IRQ mode

Enables Multi-IRQ mode for the S32 GMAC driver when per-queue IRQs
are present and more than one RX queue is configured.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c
> index 5a485ee98fa7..37a5b7b46973 100644

[ ... ]

> @@ -149,6 +149,16 @@ static int s32_dwmac_probe(struct platform_device *pdev)
>  	plat->core_type = DWMAC_CORE_GMAC4;
>  	plat->pmt = 1;
>  	plat->flags |= STMMAC_FLAG_SPH_DISABLE;
> +
> +	/* Check for multi-IRQ config. Assumption: symetrical rx/tx queues */
                                                   ^^^^^^^^^^

This isn't a bug, but "symetrical" should be "symmetrical".