linux-kernel - Re: [PATCH v3 3/3] pinctrl: aspeed: add G7(AST2700) SoC0 pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSQPR06MB7252CAA1FCE83EAFF43FECC98B9EA@OSQPR06MB7252.apcprd06.prod.outlook.com>
Date: Thu, 29 Jan 2026 06:43:02 +0000
From: Billy Tsai <billy_tsai@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Lee Jones <lee@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Linus Walleij <linusw@...nel.org>, Bartosz
 Golaszewski <brgl@...nel.org>
CC: Andrew Jeffery <andrew@...id.au>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject: Re: [PATCH v3 3/3] pinctrl: aspeed: add G7(AST2700) SoC0 pinctrl
 support

Hi Krzysztof,

> > +
> > +static const struct aspeed_pinmux_ops aspeed_g7_soc0_ops = {
> > +     .set = aspeed_g7_soc0_sig_expr_set,
> > +};
> > +
> > +static struct aspeed_pinctrl_data aspeed_g7_soc0_pinctrl_data = {

> Look at your existing drivers - what is missing here and in other places?

Based on existing drivers (like pinctrl-aspeed-g6.c), aspeed_pin_group,
aspeed_pin_function arrays and pinctrl_desc should be const. I will add
const to aspeed_g7_soc0_groups, aspeed_g7_soc0_functions and
aspeed_g7_soc0_pinctrl_desc.

However, aspeed_pinctrl_data itself is not const in existing drivers
(likely because it holds mutable data like regmaps). If you strictly meant
pinctrl_data should be const, please let me know, but I suspect you were
referring to the referenced arrays and consistency.

Best regards,

Billy Tsai