linux-kernel - [PATCH] drivers: pwm: remove redundant check in pwm_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260129-fix-pwm-ops-check-v1-1-6f0b7952c875@andestech.com>
Date: Thu, 29 Jan 2026 14:43:34 +0800
From: Ben Zong-You Xie via B4 Relay <devnull+ben717.andestech.com@...nel.org>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
 linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Ben Zong-You Xie <ben717@...estech.com>
Subject: [PATCH] drivers: pwm: remove redundant check in pwm_ops_check()

From: Ben Zong-You Xie <ben717@...estech.com>

Drop the redundant check for the existence of 'ops->write_waveform'.

Fixes: 17e40c25158f ("pwm: New abstraction for PWM waveforms")
Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>
---
 drivers/pwm/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index ec8731515333..450aedd32c81 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1699,8 +1699,7 @@ static bool pwm_ops_check(const struct pwm_chip *chip)
 
 	if (ops->write_waveform) {
 		if (!ops->round_waveform_tohw ||
-		    !ops->round_waveform_fromhw ||
-		    !ops->write_waveform)
+		    !ops->round_waveform_fromhw)
 			return false;
 
 		if (PWM_WFHWSIZE < ops->sizeof_wfhw) {

---
base-commit: 63faf32666e03a78cc985bcbae196418cf7d7938
change-id: 20260129-fix-pwm-ops-check-6e36ce09d75a

Best regards,
--  
Ben Zong-You Xie <ben717@...estech.com>