linux-kernel - Re: [PATCH] drivers: pwm: remove redundant check in pwm_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jxzeyujbaj6s2j3woj7lyuilwi7tzlhenamlih2q23khxw4d3f@dpbnhlxzsjmr>
Date: Thu, 29 Jan 2026 08:19:00 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: ben717@...estech.com
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: pwm: remove redundant check in pwm_ops_check()

Hello Ben,

thanks for your patch.

On Thu, Jan 29, 2026 at 02:43:34PM +0800, Ben Zong-You Xie via B4 Relay wrote:
> From: Ben Zong-You Xie <ben717@...estech.com>
> 
> Drop the redundant check for the existence of 'ops->write_waveform'.
> 
> Fixes: 17e40c25158f ("pwm: New abstraction for PWM waveforms")
> Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>

I would rewrite the commit log to:

	pwm: Remove redundant check in pwm_ops_check()

	ops->write_waveform is already known to be non-NULL so there is
	no need to check it a second time.

	The superflous check was introduced in commit 17e40c25158f
	("pwm: New abstraction for PWM waveforms").

	Signed-off-by: Ben Zong-You Xie <ben717@...estech.com>

to make the change more clear and also to not bother the stable team
with backporting the commit to stable.

Please confirm if you're ok with this change, then I cope for the update
while applying your change.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)