linux-kernel - Re: [PATCH] pinctrl: renesas: rzt2h: Fix device node leak in rzt2h_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXvS9QyL3UbfWq3KW=vfpLG8Bg4LfzGw9uYn0CfJSEj-Q@mail.gmail.com>
Date: Thu, 29 Jan 2026 09:09:10 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Linus Walleij <linusw@...nel.org>
Cc: Felix Gu <ustc.gu@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Thierry Bultel <thierry.bultel.yh@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: rzt2h: Fix device node leak in rzt2h_gpio_register()

Hi Linus,

On Wed, 28 Jan 2026 at 08:55, Linus Walleij <linusw@...nel.org> wrote:
> On Mon, Jan 26, 2026 at 5:35 PM Felix Gu <ustc.gu@...il.com> wrote:
>
> > +       of_node_put(of_args.np);
> >         if (of_args.args[0] != 0 || of_args.args[1] != 0 ||
> >             of_args.args[2] != pctrl->data->n_port_pins)
> >                 return dev_err_probe(dev, -EINVAL,
>
> To me it's a bit odd to dereference .np and then use other parts of
> the args the next line but maybe that works.

The of_node pointer is not used at all. The code only needs to validate
the mapping numbers.

> Geert will decide on the patch.

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-pinctrl for v6.21.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds