linux-kernel - Re: [PATCH v2] staging: rtl8723bs: refactor BSS Coexistence channel report logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026012943-danger-tweed-8f81@gregkh>
Date: Thu, 29 Jan 2026 09:54:35 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Michael Huang <tehsiu.huang@...il.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Joe Perches <joe@...ches.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: refactor BSS Coexistence channel
 report logic

On Thu, Jan 29, 2026 at 12:01:10AM -0800, Michael Huang wrote:
> Refactor the 'ICS' array in issue_action_BSSCoexistPacket() to improve
> readability and maintainability. This addresses technical debt related
> to magic numbers and ambiguous array usage.
> 
> The original implementation used a multi-purpose 2D array (ICS[8][15])
> where magic numbers were prevalent and the first element of each row
> was overloaded as a status flag. This patch:
> 
> - Introduces descriptive macros: BSS_COEX_MAX_CLASSES,
>   BSS_COEX_MAX_CHANNELS, and BSS_COEX_MAX_INFO_LEN.
> - Splits the overloaded array into two distinct boolean arrays:
>   'class_active' (for group status) and 'ch_present' (for channel data).
> - Converts the logic to use 'bool' types and 0-indexed loops,
>   conforming to standard C programming practices.
> - Adds defensive boundary checks (ch > 0 && ch < MAX) to ensure
>   robustness against unexpected channel data.

That's a lot of different things all in one single patch.  SHouldn't
this be split up into different ones?

And did you use AI to generate this patch?

Also, how was this tested?  What prompted you to want to make this
change in the first place?

thanks,

greg k-h