linux-kernel - Re: [PATCH v2] staging: rtl8723bs: refactor BSS Coexistence channel report logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMbZB6NhWzPhNB2fiyxyNoqd+=y93JYp0NdQykyEgsL9=qT7-Q@mail.gmail.com>
Date: Thu, 29 Jan 2026 01:54:37 -0800
From: Te-Hsiu Huang <tehsiu.huang@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Joe Perches <joe@...ches.com>, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: refactor BSS Coexistence channel
 report logic

On Thu, Jan 29, 2026 at 12:54 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:

> That's a lot of different things all in one single patch.  SHouldn't
> this be split up into different ones?
I kept these changes in one patch because they all work together to
replace the old ICS logic and remove the magic numbers. Splitting them
might break the build or make the code inconsistent halfway through.
I was suggested renaming and using a bool array structure in the
earlier patch here:
https://lore.kernel.org/all/e87acd109ea5eb4e3f8fc233788cd0dbd128407d.camel@perches.com/
I kept the 2D structure to maintain parity with the IEEE 802.11 spec
as original implementation. It makes the code semantically correct and
easier to extend for other Operating Classes in the future.

> And did you use AI to generate this patch?
I used AI tools to polish the language of my commit message and to
perform a parity check, ensuring the refactored boolean logic is
functionally identical to the original code.

> Also, how was this tested?  What prompted you to want to make this
> change in the first place?
The patch was tested by:
1. Cross-compile the module for the rtl8723bs driver (make
M=drivers/staging/rtl8723bs) to ensure no build regressions.
2. Ran it through scripts/checkpatch.pl to confirm it meets kernel
coding standards.
3. Since I do not have the physical hardware, I performed a manual
check (by AI verification) to ensure the logic remains identical.
Specifically:
    - The original code used ICS[0][ch] to store channel data.
    - The new code uses ch_present[0][ch] for the same purpose.
    - The original ICS[i][0] flag is now explicitly class_active[i].
    - Verified that the loop boundaries and index offsets (0-15)
remain exactly the same as the original implementation.

Motivation: This follows up on the cleanup tasks suggested during the
previous discussion in
https://lore.kernel.org/all/e87acd109ea5eb4e3f8fc233788cd0dbd128407d.camel@perches.com.
I want to improve the readability of the driver by removing magic numbers.
>
> thanks,
>
> greg k-h

Thanks,
Michael