linux-kernel - Re: [PATCH] wifi: ath10k: sdio: add missing lock protection in ath10k_sdio_fw_crashed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176978613677.3951544.12305626465860433221.b4-ty@oss.qualcomm.com>
Date: Fri, 30 Jan 2026 07:15:36 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Jeff Johnson <jjohnson@...nel.org>, Ziyi Guo <n7l8m4@...orthwestern.edu>
Cc: linux-wireless@...r.kernel.org, ath10k@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath10k: sdio: add missing lock protection in
 ath10k_sdio_fw_crashed_dump()


On Fri, 23 Jan 2026 04:58:22 +0000, Ziyi Guo wrote:
> ath10k_sdio_fw_crashed_dump() calls ath10k_coredump_new() which requires
> ar->dump_mutex to be held, as indicated by lockdep_assert_held() in that
> function. However, the SDIO implementation does not acquire this lock,
> unlike the PCI and SNOC implementations which properly hold the mutex.
> 
> Additionally, ar->stats.fw_crash_counter is documented as protected by
> ar->data_lock in core.h, but the SDIO implementation modifies it without
> holding this spinlock.
> 
> [...]

Applied, thanks!

[1/1] wifi: ath10k: sdio: add missing lock protection in ath10k_sdio_fw_crashed_dump()
      commit: e55ac348089e579fc224569c7bd90340bf2439f9

Best regards,
-- 
Jeff Johnson <jeff.johnson@....qualcomm.com>