linux-kernel - Re: [PATCH] mm/damon: remove __read_mostly from memory_idle_ms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260130153813.784-1-sj@kernel.org>
Date: Fri, 30 Jan 2026 07:38:12 -0800
From: SeongJae Park <sj@...nel.org>
To: lirongqing <lirongqing@...du.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/damon: remove __read_mostly from memory_idle_ms_percentiles

On Fri, 30 Jan 2026 03:56:03 -0500 lirongqing <lirongqing@...du.com> wrote:

> From: Li RongQing <lirongqing@...du.com>
> 
> The 'memory_idle_ms_percentiles' array in DAMON_STAT is updated
> frequently by the kernel to reflect the latest idle time statistics.
> Marking it as '__read_mostly' is inappropriate for data that is
> regularly written to, as it can lead to cache pollution in the
> read-mostly section.
> 
> Remove the '__read_mostly' annotation to accurately reflect the
> variable's usage pattern.

Nice catch, thank you Li!

> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]