linux-kernel - Re: [PATCH v9 06/22] x86/cea: Export __this_cpu_ist_top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <78858200-FE67-491E-89C6-5906233C860D@zytor.com>
Date: Fri, 30 Jan 2026 08:35:50 -0800
From: Xin Li <xin@...or.com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, pbonzini@...hat.com, seanjc@...gle.com,
        corbet@....net, tglx@...utronix.de, mingo@...hat.com,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        luto@...nel.org, peterz@...radead.org, andrew.cooper3@...rix.com,
        chao.gao@...el.com, hch@...radead.org, sohil.mehta@...el.com
Subject: Re: [PATCH v9 06/22] x86/cea: Export __this_cpu_ist_top_va() to KVM



> On Jan 30, 2026, at 5:46 AM, Borislav Petkov <bp@...en8.de> wrote:
> 
> On Sun, Oct 26, 2025 at 01:18:54PM -0700, Xin Li (Intel) wrote:
>> @@ -36,6 +41,7 @@ noinstr unsigned long __this_cpu_ist_top_va(enum exception_stack_ordering stack)
>> {
>> return __this_cpu_ist_bottom_va(stack) + EXCEPTION_STKSZ;
>> }
>> +EXPORT_SYMBOL_FOR_MODULES(__this_cpu_ist_top_va, "kvm-intel");
> 
> Why is this function name still kept with the "__" prefix but it is being
> exported at the same time?
> 
> It looks to me like we're exporting the wrong thing as the "__" kinda says it
> is an internal helper.
> 
> Just drop the prefix and call it something more sensible please. The caller
> couldn't care less about "ist_top_va".

Right, the “__” prefix no longer makes sense.

What is the right order of rename and refactor?

I think we usually do renames in the first patch and then refactor in a following patch.