linux-kernel - Re: [PATCH v9 06/22] x86/cea: Export __this_cpu_ist_top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260130134644.GUaXy2RNbwEaRSgLUN@fat_crate.local>
Date: Fri, 30 Jan 2026 14:46:44 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Xin Li (Intel)" <xin@...or.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	linux-doc@...r.kernel.org, pbonzini@...hat.com, seanjc@...gle.com,
	corbet@....net, tglx@...utronix.de, mingo@...hat.com,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	luto@...nel.org, peterz@...radead.org, andrew.cooper3@...rix.com,
	chao.gao@...el.com, hch@...radead.org, sohil.mehta@...el.com
Subject: Re: [PATCH v9 06/22] x86/cea: Export __this_cpu_ist_top_va() to KVM

On Sun, Oct 26, 2025 at 01:18:54PM -0700, Xin Li (Intel) wrote:
> @@ -36,6 +41,7 @@ noinstr unsigned long __this_cpu_ist_top_va(enum exception_stack_ordering stack)
>  {
>  	return __this_cpu_ist_bottom_va(stack) + EXCEPTION_STKSZ;
>  }
> +EXPORT_SYMBOL_FOR_MODULES(__this_cpu_ist_top_va, "kvm-intel");

Why is this function name still kept with the "__" prefix but it is being
exported at the same time?

It looks to me like we're exporting the wrong thing as the "__" kinda says it
is an internal helper.

Just drop the prefix and call it something more sensible please. The caller
couldn't care less about "ist_top_va".

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette