linux-kernel - RE: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_ras

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB8796F7F06A2F1DEC1FDAD683B09FA@PH7PR12MB8796.namprd12.prod.outlook.com>
Date: Fri, 30 Jan 2026 03:20:39 +0000
From: "Zhou1, Tao" <Tao.Zhou1@....com>
To: Zilin Guan <zilin@....edu.cn>, "Deucher, Alexander"
	<Alexander.Deucher@....com>
CC: "Koenig, Christian" <Christian.Koenig@....com>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>, "Zhang, Hawking"
	<Hawking.Zhang@....com>, "Chai, Thomas" <YiPeng.Chai@....com>, "Xie, Patrick"
	<Gangliang.Xie@....com>, "Yang, Stanley" <Stanley.Yang@....com>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jianhao.xu@....edu.cn" <jianhao.xu@....edu.cn>
Subject: RE: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_ras_init()

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks for the catch,

Reviewed-by: Tao Zhou <tao.zhou1@....com>

> -----Original Message-----
> From: Zilin Guan <zilin@....edu.cn>
> Sent: Thursday, January 29, 2026 4:35 PM
> To: Deucher, Alexander <Alexander.Deucher@....com>
> Cc: Koenig, Christian <Christian.Koenig@....com>; airlied@...il.com;
> simona@...ll.ch; Zhou1, Tao <Tao.Zhou1@....com>; Zhang, Hawking
> <Hawking.Zhang@....com>; Chai, Thomas <YiPeng.Chai@....com>; Xie,
> Patrick <Gangliang.Xie@....com>; Yang, Stanley <Stanley.Yang@....com>;
> amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org; jianhao.xu@....edu.cn; Zilin Guan <zilin@....edu.cn>
> Subject: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_ras_init()
>
> When amdgpu_nbio_ras_sw_init() fails in amdgpu_ras_init(), the function returns
> directly without freeing the allocated con structure, leading to a memory leak.
>
> Fix this by jumping to the release_con label to properly clean up the allocated
> memory before returning the error code.
>
> Compile tested only. Issue found using a prototype static analysis tool and code
> review.
>
> Fixes: fdc94d3a8c88 ("drm/amdgpu: Rework pcie_bif ras sw_init")
> Signed-off-by: Zilin Guan <zilin@....edu.cn>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 2a6cf7963dde..8de9f68f7bea 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -4343,7 +4343,7 @@ int amdgpu_ras_init(struct amdgpu_device *adev)
>        * to handle fatal error */
>       r = amdgpu_nbio_ras_sw_init(adev);
>       if (r)
> -             return r;
> +             goto release_con;
>
>       if (adev->nbio.ras &&
>           adev->nbio.ras->init_ras_controller_interrupt) {
> --
> 2.34.1