[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEQ9gEm158YKRPa6V2rOnrgnRxkrXSrbb-WZh5rh7SDGVLM7xA@mail.gmail.com>
Date: Thu, 29 Jan 2026 19:20:48 -0800
From: Roger Shimizu <rosh@...ian.org>
To: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Hongyang Zhao <hongyang.zhao@...ndersoft.com>
Subject: Re: [PATCH] drm/bridge: lt9611: Remove I2C address change in sleep
On Thu, Jan 29, 2026 at 1:36 PM Hongyang Zhao
<hongyang.zhao@...ndersoft.com> wrote:
>
> The lt9611_sleep_setup() modifies the chip's I2C address via registers
> 0x8023/0x8024 and reconfigures GPIO0 via 0x8157/0x8149. Since there is
> no corresponding restore in the wake-up path, I2C communication fails
> after resume.
>
> Remove the I2C address and GPIO reconfiguration from sleep setup. The
> MIPI Rx power-down and TX PHY disable sequences are sufficient.
>
> Signed-off-by: Hongyang Zhao <hongyang.zhao@...ndersoft.com>
> ---
> The lt9611_sleep_setup() function modifies the chip's I2C address via
> registers 0x8023/0x8024 and reconfigures GPIO0. However, there is no
> corresponding restore in the wake-up path, which causes I2C communication
> to fail after resume.
>
> This patch removes the I2C address and GPIO reconfiguration from sleep
> setup. The MIPI Rx power-down and TX PHY disable sequences are sufficient
> for proper sleep operation.
>
> Tested on RubikPi3 (QCS6490) platform with the LT9611 HDMI bridge.
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index a2d032ee4744..ae47efe9d77f 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -424,11 +424,6 @@ static void lt9611_enable_hpd_interrupts(struct lt9611 *lt9611)
> static void lt9611_sleep_setup(struct lt9611 *lt9611)
> {
> const struct reg_sequence sleep_setup[] = {
> - { 0x8024, 0x76 },
> - { 0x8023, 0x01 },
> - { 0x8157, 0x03 }, /* set addr pin as output */
> - { 0x8149, 0x0b },
> -
> { 0x8102, 0x48 }, /* MIPI Rx power down */
> { 0x8123, 0x80 },
> { 0x8130, 0x00 },
>
> ---
Tested-by: Roger Shimizu <rosh@...ian.org> # Rubik Pi 3 (QCOM QCS6490 platform)
Before this patch, HDMI output can be used just after booting / 1st plugging in.
HDMI gets lost after the disconnecting, and plugging in again.
-Roger
Powered by blists - more mailing lists