linux-kernel - Re: [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h preparation for Redirect irqchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875x8jmsa8.ffs@tglx>
Date: Fri, 30 Jan 2026 09:14:07 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Tianyang Zhang <zhangtianyang@...ngson.cn>, chenhuacai@...nel.org,
 kernel@...0n.name, corbet@....net, alexs@...nel.org, si.yanteng@...ux.dev,
 jiaxun.yang@...goat.com, maobibo@...ngson.cn
Cc: loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Tianyang Zhang <zhangtianyang@...ngson.cn>
Subject: Re: [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h
 preparation for Redirect irqchip

On Fri, Jan 30 2026 at 10:59, Tianyang Zhang wrote:

The subject line is broken and incomprehensible. Something like:

    irqchip/irq-loonarch-avec: Prepare for interrupt redirection support

is concise and gives context.

> Adjusted definitions and macro from loongson-avec.c to irq-loongson.h,
> including:
> 1 marco AVEC_MSG_OFFSET
> 2 struct avecintc_data
> 3 Make avecintc_sync public

That's not a change log because it only tells _what_ the patch is doing,
but not _why_. Enumerating the details of what is moved is a pointless
exercise because that can bee seen from the diff itself.

So you want something like:

  Interrupt redirection support requires a new interrupt chip, which
  needs to share data structures, constants and functions with the AVEC
  code.

  Move them to the header file and make the required functions public.

See?