linux-kernel - Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported ICE feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com>
Date: Fri, 30 Jan 2026 10:34:26 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sumit Garg <sumit.garg@...nel.org>, linux-arm-msm@...r.kernel.org
Cc: andersson@...nel.org, konradybcio@...nel.org, abelvesa@...nel.org,
        mani@...nel.org, linux-kernel@...r.kernel.org,
        Sumit Garg <sumit.garg@....qualcomm.com>
Subject: Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported
 ICE feature

On 1/30/26 10:11 AM, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@....qualcomm.com>
> 
> ICE related SCM calls may not be supported in every TZ environment like
> OP-TEE or a no-TZ environment too. So let's try to avoid probe deferring
> when it's known that ICE feature isn't supported.
> 
> This problem only came to notice after the inline encryption drivers were
> enabled in the arm64 defconfig by: commit 5f37788adedd ("arm64: defconfig:
> Enable SCSI UFS Crypto and Block Inline encryption drivers").
> 
> Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
> Signed-off-by: Sumit Garg <sumit.garg@....qualcomm.com>
> ---
>  drivers/soc/qcom/ice.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c
> index b203bc685cad..ab9586b8caf5 100644
> --- a/drivers/soc/qcom/ice.c
> +++ b/drivers/soc/qcom/ice.c
> @@ -652,7 +652,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev)
>  		dev_err(dev, "Cannot get ice instance from %s\n",
>  			dev_name(&pdev->dev));
>  		platform_device_put(pdev);
> -		return ERR_PTR(-EPROBE_DEFER);
> +		return NULL;

Wouldn't this wreck the "actually need to defer" case, i.e.


qcom,ufs probes first
  calls devm_of_qcom_ice_get()
    "ice" reg is missing, non-legacy case
      qcom,ice is absent (not yet probed)
        return NULL

...

qcom,ice probes

?

Konrad