linux-kernel - [PATCH] ARM: dts: ti/omap: dra7: Fix PCIe PHY divided clock generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20260130093550.751250-1-dannybaumann@web.de>
Date: Fri, 30 Jan 2026 10:35:50 +0100
From: Danny Baumann <dannybaumann@....de>
To: devicetree@...r.kernel.org,
	linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	aaro.koskinen@....fi,
	andreas@...nade.info,
	khilman@...libre.com,
	rogerq@...nel.org,
	tony@...mide.com
Cc: Danny Baumann <danny.baumann@...rand.com>,
	stable@...r.kernel.org
Subject: [PATCH] ARM: dts: ti/omap: dra7: Fix PCIe PHY divided clock generation

From: Danny Baumann <danny.baumann@...rand.com>

Commit d0bdd8bb7f35a2b4434a3ef665f9cfc3aba886c7 ("ARM: dts: ti/omap:
dra7: fix redundant clock divider definition") removed the ti,dividers
property in favor of the ti,max-div property. That particular divider is
'backwards', though (0 = 'divide by 2', 1 = 'do not divide, see AM574x
TRM, table 3-846 on page 939), so the removal of that property inverted
the driver behavior.
Restore previous behavior by restoring the ti,dividers property and fix
the redundancy by removing the ti,max-div property instead.

Fixes: d0bdd8bb7f35 ("ARM: dts: ti/omap: dra7: fix redundant clock divider definition")
Cc: Andreas Kemnade <andreas@...nade.info>
Cc: Kevin Hilman <khilman@...libre.com>
Cc: stable@...r.kernel.org # 6.13+
Signed-off-by: Danny Baumann <danny.baumann@...rand.com>
---
 arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi b/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
index 0de16ee262cf..615a8fb47776 100644
--- a/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
@@ -1376,8 +1376,8 @@ optfclk_pciephy_div: clock-optfclk-pciephy-div-8@...0821c {
 		clocks = <&apll_pcie_ck>;
 		#clock-cells = <0>;
 		reg = <0x021c>;
+		ti,dividers = <2>, <1>;
 		ti,bit-shift = <8>;
-		ti,max-div = <2>;
 	};
 
 	apll_pcie_clkvcoldo: clock-apll-pcie-clkvcoldo {
-- 
2.52.0