linux-kernel - Re: [PATCH v2 1/4] include/asm-generic/topology.h: Remove unused definition of cpumask_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1171c2c1-1d9e-49ad-8d94-ede3c68c9f9c@oracle.com>
Date: Fri, 30 Jan 2026 12:24:09 +0000
From: John Garry <john.g.garry@...cle.com>
To: arnd@...db.de
Cc: loongarch@...ts.linux.dev, peterz@...radead.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-arch@...r.kernel.org, vulab@...as.ac.cn,
        gregkh@...uxfoundation.org, x86@...nel.org, rafael@...nel.org,
        dakr@...nel.org, luto@...nel.org, hpa@...or.com,
        tsbogend@...ha.franken.de, mingo@...hat.com,
        dave.hansen@...ux.intel.com, bp@...en8.de, jiaxun.yang@...goat.com,
        kernel@...0n.name, chenhuacai@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH v2 1/4] include/asm-generic/topology.h: Remove unused
 definition of cpumask_of_node()

On 07/01/2026 09:40, John Garry wrote:
> The definition of cpumask_of_node() in question is guarded by conflicting
> CONFIG_NUMA and !CONFIG_NUMA checks, so remove it.

Arnd, can you consider picking this up please?

Thanks

> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
>   include/asm-generic/topology.h | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/include/asm-generic/topology.h b/include/asm-generic/topology.h
> index 4dbe715be65b4..9865ba48c5b16 100644
> --- a/include/asm-generic/topology.h
> +++ b/include/asm-generic/topology.h
> @@ -45,11 +45,7 @@
>   #endif
>   
>   #ifndef cpumask_of_node
> -  #ifdef CONFIG_NUMA
> -    #define cpumask_of_node(node)	((node) == 0 ? cpu_online_mask : cpu_none_mask)
> -  #else
> -    #define cpumask_of_node(node)	((void)(node), cpu_online_mask)
> -  #endif
> +#define cpumask_of_node(node)	((void)(node), cpu_online_mask)
>   #endif
>   #ifndef pcibus_to_node
>   #define pcibus_to_node(bus)	((void)(bus), -1)
> @@ -61,7 +57,7 @@
>   				 cpumask_of_node(pcibus_to_node(bus)))
>   #endif
>   
> -#endif	/* CONFIG_NUMA */
> +#endif	/* !CONFIG_NUMA */
>   
>   #if !defined(CONFIG_NUMA) || !defined(CONFIG_HAVE_MEMORYLESS_NODES)
>