linux-kernel - Re: [PATCH] scsi: libsas: Fix dev_list race conditions with proper locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aX3dpqtLmgNVaQEg@LAPTOP-RK2E6KJ3.localdomain>
Date: Sat, 31 Jan 2026 18:47:02 +0800
From: Chaohai Chen <wdhh6@...yun.com>
To: Jason Yan <yanaijie@...wei.com>
Cc: john.g.garry@...cle.com, James.Bottomley@...senpartnership.com,
	martin.petersen@...cle.com, dlemoal@...nel.org,
	johannes.thumshirn@....com, mingo@...nel.org, cassel@...nel.org,
	tglx@...nel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: libsas: Fix dev_list race conditions with proper
 locking

On Fri, Jan 30, 2026 at 04:27:11PM +0800, Jason Yan wrote:
> Hi,
> 
> 在 2026/1/29 17:38, Chaohai Chen 写道:
> > Multiple functions in libsas were accessing port->dev_list without
> > proper locking, leading to potential race conditions that could cause:
> > - Use-after-free when devices are removed during list traversal
> > - List corruption from concurrent modifications
> > - System crashes from accessing freed memory
> 
> libsas events are processed in orderd workqueue. Do you have a crash log?
No crash log. I noticed the missing locks while watching the code. But
there are tow queues, event_q and disco_q which may cause conflicts.
And I think the dev_ist_lock is designed to prevent conflicts.
> 
> Thanks,
> 祝一切顺利

--
Chaohai Chen