linux-kernel - Re: [PATCH v5 16/31] clk: at91: clk-plldiv: add support for parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49022192-04b9-4ed8-baeb-706edb6e1322@tuxon.dev>
Date: Sat, 31 Jan 2026 12:51:41 +0200
From: claudiu beznea <claudiu.beznea@...on.dev>
To: ryan.wanner@...rochip.com, mturquette@...libre.com, sboyd@...nel.org,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 bmasney@...hat.com, alexander.sverdlin@...il.com,
 varshini.rajendran@...rochip.com
Cc: cristian.birsan@...rochip.com, balamanikandan.gunasundar@...rochip.com,
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 16/31] clk: at91: clk-plldiv: add support for
 parent_data



On 1/16/26 22:07, ryan.wanner@...rochip.com wrote:
> From: Claudiu Beznea<claudiu.beznea@...on.dev>
> 
> Add support for parent_data in plldiv clock driver.

I would replace the following:

> With this parent-child relation is described with pointers rather
> than strings making registration a bit faster.

with something like what you have used in patch 13/31:

"Having this allows the driver to conform to the new clk-system API."

As with parent_data you could describe the parent-child relationship with either 
struct clk_hw pointers, clk names, indexes...

Valid for the rest of the patches that uses the same description.

> 
> All the SoC based drivers that rely on clk-plldiv were adapted
> to the new API change. The switch itself for SoCs will be done
> in subsequent patches.
> 
> Signed-off-by: Claudiu Beznea<claudiu.beznea@...on.dev>
> Signed-off-by: Ryan Wanner<Ryan.Wanner@...rochip.com>

With those addressed:

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>