linux-kernel - Re: [PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZCWcWaDGSFVvV0AT3rp7pO+iPXNnXW+4Dum9PwOFy3nQA@mail.gmail.com>
Date: Tue, 3 Feb 2026 15:59:04 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Russell King <linux@...linux.org.uk>, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1

On Mon, Feb 2, 2026 at 9:45 PM Frank Li <Frank.Li@....com> wrote:
>
> Rename at45db321d@1 to flash@1 to fix below CHECK_DTBS warnings:
> at45db321d@1 (atmel,at45db321d): $nodename:0: 'at45db321d@1' does not match '^(flash|.*sram|nand)(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/mtd/atmel,dataflash.yaml
>

The commit message should say *why* the commit is needed and not
focus on fixing the warnings from a tool.

e.g:

ARM: dts: imx51-babbage: Use generic name for flash node

Prefer generic node name 'flash' over the existing specific one to reflect
the function of the device.

This fixes below CHECK_DTBS warning:
 at45db321d@1 (atmel,at45db321d): $nodename:0: 'at45db321d@1' does not
match '^(flash|.*sram|nand)(@.*)?$'
         from schema $id: http://devicetree.org/schemas/mtd/atmel,dataflash.yaml

<snip>

> -       flash: at45db321d@1 {
> +       flash: flash@1 {
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 compatible = "atmel,at45db321d", "atmel,at45", "atmel,dataflash";
>

Thanks,
Daniel.