linux-kernel - Re: [PATCH v2] rust: Makefile: bound rustdoc workaround to affected versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DG5EXHDFRTWZ.WLWRUDWF9NSM@garyguo.net>
Date: Tue, 03 Feb 2026 14:56:44 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>, "HeeSu Kim"
 <mlksvender@...il.com>, "Nathan Chancellor" <nathan@...nel.org>, "Nicolas
 Schier" <nsc@...nel.org>
Cc: <ojeda@...nel.org>, <gary@...yguo.net>, <charmitro@...teo.net>,
 <a.hindborg@...nel.org>, <aliceryhl@...gle.com>,
 <bjorn3_gh@...tonmail.com>, <boqun@...gle.com>, <dakr@...nel.org>,
 <lossin@...nel.org>, <tmgross@...ch.edu>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Linux Kbuild mailing list"
 <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2] rust: Makefile: bound rustdoc workaround to affected
 versions

On Mon Feb 2, 2026 at 4:00 PM GMT, Miguel Ojeda wrote:
> On Mon, Feb 2, 2026 at 4:21 PM HeeSu Kim <mlksvender@...il.com> wrote:
>>
>> This bug was fixed in Rust 1.90.0 (rust-lang/rust#144523). Restrict
>
> Normally these references should be full links (i.e. a tag), since we
> do not have "autolinking" like GitHub e.g.
>
>   Link: https://........ [1]
>
> Then you can use [1] above instead of the parenthesis.
>
>> are affected by the bug, avoiding unnecessary flags on newer compiler
>
> To clarify a bit: avoiding the flags is good, but I think avoiding the
> skipping of the checks that the flag does is what is more important
> (i.e. if it were just the former advantage, I would say it is not
> worth the complexity of the added tests).

I think skipping workarounds when possible is in general good, as it serves a
good reference that it can be removed whenever the toolchain minimum version is
bumped above that (and with the help with LKP, it means that it's also been
actually widely tested that the workaround is indeed not necessary).

Best,
Gary