linux-kernel - Re: [PATCH v4 2/4] staging: rtl8723bs: replace rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYIQLjkhSfTvYJif@smile.fi.intel.com>
Date: Tue, 3 Feb 2026 17:11:42 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Minu Jin <s9430939@...er.com>
Cc: gregkh@...uxfoundation.org, dan.carpenter@...aro.org,
	trohan2000@...il.com, andy@...nel.org,
	linux-staging@...ts.linux.dev, straube.linux@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] staging: rtl8723bs: replace rtw_zmalloc() with
 kzalloc()

On Sun, Feb 01, 2026 at 04:29:59AM +0900, Minu Jin wrote:
> replaces the wrapper function rtw_zmalloc() with kzalloc().
> 
> I reviewed all the call sites to determine the appropriate GFP flags:
> - GFP_KERNEL: Used for initialization and configuration paths.
>   init/probe, config/setup
> 
> - GFP_ATOMIC: Used for critical real-time paths.
>   including interrupts, timer handler, region where spinlocks are held
> 
> Replace sizeof(struct val) with sizeof(*ptr).

> Use kmemdup() where possible.

Shouldn't be here. Are there kmemdup() conversions?
So, collect kmemdup() in the first (currently absent) patch followed by
kmalloc() followed by this change.

> Remove blank line after kzalloc().

-- 
With Best Regards,
Andy Shevchenko