linux-kernel - Re: [PATCH v4 3/4] staging: rtl8723bs: replace skb allocation, copy wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYIQfJratRz-H5N6@smile.fi.intel.com>
Date: Tue, 3 Feb 2026 17:13:00 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Minu Jin <s9430939@...er.com>
Cc: gregkh@...uxfoundation.org, dan.carpenter@...aro.org,
	trohan2000@...il.com, andy@...nel.org,
	linux-staging@...ts.linux.dev, straube.linux@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/4] staging: rtl8723bs: replace skb allocation, copy
 wrappers

On Sun, Feb 01, 2026 at 04:30:00AM +0900, Minu Jin wrote:
> Replace the wrapper functions rtw_skb_alloc() and rtw_skb_copy() with
> kernel APIs __dev_alloc_skb() and skb_copy().
> 
> I used GFP_ATOMIC for the network data paths  because these
> functions are called in contexts where the driver cannot sleep.

...

> -			precvbuf->pskb = rtw_skb_alloc(MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ);
> +			precvbuf->pskb = __dev_alloc_skb(MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ, GFP_ATOMIC);

>  

Drop this blank line for the consistency's sake (other cases use no blank line style).

>  			if (precvbuf->pskb) {
>  				precvbuf->pskb->dev = padapter->pnetdev;

...

> -		newskb = rtw_skb_copy(skb);
> +		newskb = skb_copy(skb, GFP_ATOMIC);
>  

Ditto.

>  		if (newskb) {
>  			memcpy(newskb->data, psta->hwaddr, 6);

-- 
With Best Regards,
Andy Shevchenko