[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <DG4ZA0AFOSQI.J5EJQMPYPV7K@gmail.com>
Date: Mon, 02 Feb 2026 21:40:47 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: Pali Rohár <pali@...nel.org>, "Kurt Borja"
<kuurtb@...il.com>
Cc: "Matthew Garrett" <mjg59@...f.ucam.org>, "Hans de Goede"
<hansg@...nel.org>, Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>, <platform-driver-x86@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>, "Olexa Bilaniuk"
<obilaniu@...il.com>
Subject: Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
On Mon Feb 2, 2026 at 12:43 PM -05, Pali Rohár wrote:
> On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
>> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
>> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> >> Add audio/mic mute key codes found in some Alienware devices.
>> >>
>> >> Cc: stable@...r.kernel.org
>> >> Tested-by: Olexa Bilaniuk <obilaniu@...il.com>
>> >> Suggested-by: Olexa Bilaniuk <obilaniu@...il.com>
>> >> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>> >> ---
>> >> drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> >> 1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> index 28076929d6af..62cf28d1fe19 100644
>> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>> >> /* Meta key unlock */
>> >> { KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>> >>
>> >> + { KE_KEY, 0x0109, { KEY_MUTE } },
>> >> + { KE_KEY, 0x0150, { KEY_MICMUTE } },
>> >
>> > Hello, please keep codes in the array sorted.
>>
>> Hi Pali,
>>
>> I thought I sorted it... I'll fix it, thanks!
>
> Before is value 0xe001 and your new values are 0x01xx. Most of values
> are 0xeXXX, so it is quite unusual that Dell allocated values with
> different pattern.
It is a bit unusual but it corresponds with the user report
dell_wmi: Unknown key with type 0x0000 and code 0x0109 pressed
dell_wmi: Unknown key with type 0x0000 and code 0x0150 pressed
and I also checked the acpidump.
>
> Also, could you please include into commit message for which Alienware
> devices is change needed? It would help to detect devices which will be
> fixed by your change.
Sure, the model is Alienware m18 r1 AMD.
I said "some" in the commit message because it's very likely other
Alienware models also use these codes.
>
> And please add some comment into source file above those two new codes
> for which are needed, in similar way how we have commented/documented
> other key codes.
Ack.
--
Thanks,
~ Kurt
Powered by blists - more mailing lists