linux-kernel - Re: [PATCH v7 1/4] dt-bindings: reset: renesas,rzv2h-usb2phy: Add '#mux-state-cells' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260203175657.GA2788294-robh@kernel.org>
Date: Tue, 3 Feb 2026 11:56:57 -0600
From: Rob Herring <robh@...nel.org>
To: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
Cc: devicetree@...r.kernel.org, biju.das.jz@...renesas.com,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-kernel@...r.kernel.org, Magnus Damm <magnus.damm@...il.com>,
	linux-renesas-soc@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, tomm.merciai@...il.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v7 1/4] dt-bindings: reset: renesas,rzv2h-usb2phy: Add
 '#mux-state-cells' property

On Tue, Feb 03, 2026 at 09:49:38AM +0100, Tommaso Merciai wrote:
> Hi Rob,
> 
> On Thu, Jan 29, 2026 at 12:42:11PM -0600, Rob Herring (Arm) wrote:
> > 
> > On Thu, 29 Jan 2026 17:52:55 +0100, Tommaso Merciai wrote:
> > > Add the '#mux-state-cells' property to support describing the USB VBUS_SEL
> > > multiplexer as a mux-controller in the Renesas RZ/V2H(P) USB2PHY binding.
> > > 
> > > The mux-controller cannot be integrated into the parent USB2PHY node
> > > because the VBUS source selector is part of a separate hardware block,
> > > not the USB2PHY block itself.
> > > 
> > > This is required to properly configure USB PHY power selection on
> > > RZ/V2H(P) and RZ/G3E SoCs.
> > > 
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> > > ---
> > > v6->v7:
> > >  - No changes
> > > 
> > > v5->v6:
> > >  - Collected KKrzysztof tag
> > > 
> > > v4->v5:
> > >  - No changes
> > > 
> > > v3->v4:
> > >  - Switch back to v2 implementation.
> > >  - Improve commit body.
> > > 
> > > v2->v3:
> > >  - Manipulate mux-controller as an internal node.
> > >  - Improved commit body.
> > > 
> > > v1->v2:
> > >  - New patch
> > > 
> > >  .../bindings/reset/renesas,rzv2h-usb2phy-reset.yaml          | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.example.dtb: reset-controller@...30000 (renesas,r9a09g057-usb2phy-reset): $nodename:0: 'reset-controller@...30000' does not match '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
> > 	from schema $id: http://devicetree.org/schemas/mux/mux-controller.yaml
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.kernel.org/project/devicetree/patch/af75145b08e24034dcf367932002079363e5dd81.1769704000.git.tommaso.merciai.xr@bp.renesas.com
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> > 
> 
> This series depends on related mux series [0].
> Was splitted the series into per subsystem series for easy merging.

It's not easier when there's a dependency. I don't care so much as long 
as this series is merged after [0] is in linux-next. But don't make the 
maintainer figure that out. Either make it clear there is a warning 
until that happens or just wait to send this until the dependency is 
applied (still need to mention any dependency that's only in linux-next 
and not mainline).

Rob

> 
> [0] https://lore.kernel.org/all/cover.1769703480.git.tommaso.merciai.xr@bp.renesas.com/
> 
> Thanks & Regards,
> Tommaso
>