linux-kernel - RE: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9374ab2503627e0dd6f62a29ab5dcde9fc0354f.camel@ibm.com>
Date: Tue, 3 Feb 2026 23:35:18 +0000
From: Viacheslav Dubeyko <Slava.Dubeyko@....com>
To: "shardulsb08@...il.com" <shardulsb08@...il.com>,
        "viro@...iv.linux.org.uk"
	<viro@...iv.linux.org.uk>
CC: "jack@...e.cz" <jack@...e.cz>, "frank.li@...o.com" <frank.li@...o.com>,
        "brauner@...nel.org" <brauner@...nel.org>,
        "linux-fsdevel@...r.kernel.org"
	<linux-fsdevel@...r.kernel.org>,
        "slava@...eyko.com" <slava@...eyko.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shardul.b@...ricsoftware.com" <shardul.b@...ricsoftware.com>,
        "glaubitz@...sik.fu-berlin.de" <glaubitz@...sik.fu-berlin.de>,
        "janak@...ricsoftware.com" <janak@...ricsoftware.com>,
        "syzbot+99f6ed51479b86ac4c41@...kaller.appspotmail.com"
	<syzbot+99f6ed51479b86ac4c41@...kaller.appspotmail.com>
Subject: RE: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

On Tue, 2026-02-03 at 04:38 +0000, Al Viro wrote:
> On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote:
> > >  out_unload_nls:
> > > -	unload_nls(sbi->nls);
> 	^^^^^^^^^^^^^^^^^^^^
> > >  	unload_nls(nls);
> > > -	kfree(sbi);
> 
> > The patch [1] fixes the issue and it in HFS/HFS+ tree already.
> 
> AFAICS, [1] lacks this removal of unload_nls() on failure exit.
> IOW, the variant in your tree does unload_nls(sbi->nls) twice...

Yeah, I think you are right here.

Shardul, you already spend the time on this solution. Could you please modify
your patch to fix the issue finally by correcting the patch that already in
HFS/HFS+ tree?

Thanks a lot,
Slava.