linux-kernel - Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4375f20e2b0d3507a0209f7129e00d360d3eb32c.camel@mpiricsoftware.com>
Date: Wed, 04 Feb 2026 09:49:20 +0530
From: Shardul Bankar <shardul.b@...ricsoftware.com>
To: Viacheslav Dubeyko <Slava.Dubeyko@....com>, "viro@...iv.linux.org.uk"
	 <viro@...iv.linux.org.uk>
Cc: "jack@...e.cz" <jack@...e.cz>, "frank.li@...o.com" <frank.li@...o.com>, 
	"brauner@...nel.org"
	 <brauner@...nel.org>, "linux-fsdevel@...r.kernel.org"
	 <linux-fsdevel@...r.kernel.org>, "slava@...eyko.com" <slava@...eyko.com>, 
	"linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>, "glaubitz@...sik.fu-berlin.de"
	 <glaubitz@...sik.fu-berlin.de>, "janak@...ricsoftware.com"
	 <janak@...ricsoftware.com>, 
	"syzbot+99f6ed51479b86ac4c41@...kaller.appspotmail.com"
	 <syzbot+99f6ed51479b86ac4c41@...kaller.appspotmail.com>, 
	shardulsb08@...il.com
Subject: Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure

On Tue, 2026-02-03 at 23:35 +0000, Viacheslav Dubeyko wrote:
> On Tue, 2026-02-03 at 04:38 +0000, Al Viro wrote:
> > On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote:
> > > >  out_unload_nls:
> > > > -       unload_nls(sbi->nls);
> >         ^^^^^^^^^^^^^^^^^^^^
> > > >         unload_nls(nls);
> > > > -       kfree(sbi);
> > 
> > > The patch [1] fixes the issue and it in HFS/HFS+ tree already.
> > 
> > AFAICS, [1] lacks this removal of unload_nls() on failure exit.
> > IOW, the variant in your tree does unload_nls(sbi->nls) twice...
> 
> Yeah, I think you are right here.
> 
> Shardul, you already spend the time on this solution. Could you
> please modify
> your patch to fix the issue finally by correcting the patch that
> already in
> HFS/HFS+ tree?
> 
> Thanks a lot,
> Slava.

Sure, will send a v2 with just the unload_nls removed.

Thanks,
Shardul