linux-kernel - Re: [PATCH] rust_binder: return p from rust_binder_transaction_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYHib3GL3Fo9raOe@google.com>
Date: Tue, 3 Feb 2026 11:56:31 +0000
From: Alice Ryhl <aliceryhl@...gle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Carlos Llamas <cmllamas@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()

On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> > 
> > Reported-by: Carlos Llamas <cmllamas@...gle.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> >  drivers/android/binder/rust_binder.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >  
> >  	if (p)
> >  		p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > -	return NULL;
> > +	return p;
> >  }
> >  
> >  static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> > 
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
> 
> Does not apply at all, what tree was this made against?

This applies on char-misc-next. It's a fix for commit c1ea31205edf,
which currently only exists in that branch.

Alice