linux-kernel - Re: [PATCH v4 11/13] iio: dac: ds4424: convert to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYHilKjWHmNTH3jg@smile.fi.intel.com>
Date: Tue, 3 Feb 2026 13:57:08 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sander Vanheule <sander@...nheule.net>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	David Jander <david@...tonic.nl>
Subject: Re: [PATCH v4 11/13] iio: dac: ds4424: convert to regmap

On Tue, Feb 03, 2026 at 10:34:31AM +0100, Oleksij Rempel wrote:
> Refactor the driver to use the regmap API.
> 
> Replace the driver-specific mutex and manual shadow buffers with the
> standard regmap infrastructure for locking and caching.
> 
> This ensures the cache is populated from hardware at probe, preventing
> state desynchronization (e.g. across suspend/resume).
> 
> Define access tables to validate the different register maps of DS44x2
> and DS44x4.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

> +#include <linux/array_size.h>
>  #include <linux/bits.h>
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/i2c.h>

>  #include <linux/kernel.h>

Side note: I expect at some point see this inclusion to be gone.

>  #include <linux/module.h>
> +#include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>

+ types.h // exempli gratia, u8 vals[] in the code

...

> +	u8 zero_buf[DS4424_MAX_DAC_CHANNELS] = { 0 };

'0' is not needed.

-- 
With Best Regards,
Andy Shevchenko