linux-kernel - Re: [PATCH v1 1/1] bug: Mark __warn_printf() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <86e45719-b97e-4b70-92ba-415eecbf3a5a@app.fastmail.com>
Date: Wed, 04 Feb 2026 17:20:27 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Peter Zijlstra" <peterz@...radead.org>, linux-kernel@...r.kernel.org
Cc: "Andrew Morton" <akpm@...ux-foundation.org>,
 "Brendan Jackman" <jackmanb@...gle.com>
Subject: Re: [PATCH v1 1/1] bug: Mark __warn_printf() with __printf() attribute

On Wed, Feb 4, 2026, at 16:59, Andy Shevchenko wrote:
> +Cc: Arnd (just FYI)
>
> On Mon, Dec 08, 2025 at 03:16:18PM +0100, Andy Shevchenko wrote:
>> __warn_printf() is using printf() type of format, and compiler
>> is not happy about them as is:
>> 
>> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>>   187 |                         vprintk(fmt, *args);
>>       |                         ^~~~~~~
>> 
>> Fix the compilation errors by adding __printf() attribute.
>> 
>> Fixes: 5c47b7f3d1a9 ("bug: Add BUG_FORMAT_ARGS infrastructure")
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Yes, I think this is the correct fix. However, Brendan's patch is
now in the tip tree as d36067d6ea00 ("bug: Hush
suggest-attribute=format for __warn_printf()").

I hadn't seen your patch but did notice as well that the one
that was merged is not ideal. I decided against sending a fixup
because it looks harmless, but if you want to rebase your patch,
feel free to add

Acked-by: Arnd Bergmann <arnd@...db.de>

      Arnd