linux-kernel - Re: [PATCH] mux: core: fix reference count leak in mux_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYOyB0_Nmp9gR_pw@pc>
Date: Wed, 4 Feb 2026 21:54:31 +0100
From: Salah Triki <salah.triki@...il.com>
To: Peter Rosin <peda@...ntia.se>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mux: core: fix reference count leak in
 mux_chip_register()

On Sat, Jan 31, 2026 at 11:03:55PM +0100, Peter Rosin wrote:
> Hi!
> 
> 
> This patch is broken. NACK.
> 
> The put_device() call that you seem to think is missing is found in the
> mux_chip_free() function, which is what should be called to clean up
> after (a successful) mux_chip_alloc().
> 
> If there really is a leak somewhere, the real problem is a missing call
> to mux_chip_free(), not a missing put_device() in mux_chip_register().
> Adding a put_device() in mux_chip_register() leads to too many calls to
> put_device().
> 
> Cheers,
> Peter

Thanks for the clarification, that makes sense. I'll drop this patch.

Best regards,
Salah