linux-kernel - Re: [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4504b830225a8fdb7407572d92b65daf390ac8a.camel@redhat.com>
Date: Wed, 04 Feb 2026 15:56:54 -0500
From: lyude@...hat.com
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	rust-for-linux@...r.kernel.org, Danilo Krummrich <dakr@...nel.org>, 
	nouveau@...ts.freedesktop.org, Miguel Ojeda <ojeda@...nel.org>, Simona
 Vetter	 <simona@...ll.ch>, Alice Ryhl <aliceryhl@...gle.com>, Shankari
 Anand	 <shankari.ak0208@...il.com>, David Airlie <airlied@...il.com>, Benno
 Lossin	 <lossin@...nel.org>, Asahi Lina <lina+kernel@...hilina.net>
Subject: Re: [PATCH v5 2/4] rust/drm: Don't setup private driver data until
 registration

On Wed, 2026-02-04 at 15:28 -0300, Daniel Almeida wrote:
> > +    pub(crate) data_is_init: AtomicBool,
> 
> What about this?
> 
> 	/**
> 	 * @registered:
> 	 *
> 	 * Internally used by drm_dev_register() and
> drm_connector_register().
> 	 */
> 	bool registered;
> 
> Can’t we use this in lieu of this flag you’ve added?

No we couldn't unfortunately. As I said before: a lot of KMS setup has
to happen prior to registration, and most of those callbacks
(atomic_check, atomic_commit, etc.) can both happen before registration
and after. And that's a lot more difficult to deal with if we don't
have access to the private driver data for any of those callbacks.

So - it really does truly need to be tracked separately.
> 
> > +