linux-kernel - Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260204074831.300311-1-bavishimithil@gmail.com>
Date: Wed,  4 Feb 2026 02:48:31 -0500
From: Mithil Bavishi <bavishimithil@...il.com>
To: andreas@...nade.info
Cc: aaro.koskinen@....fi,
	airlied@...il.com,
	bavishimithil@...il.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	jernej.skrabec@...il.com,
	jonas@...boo.se,
	khilman@...libre.com,
	krzk+dt@...nel.org,
	laurent.pinchart@...asonboard.com,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	neil.armstrong@...aro.org,
	rfoss@...nel.org,
	robh@...nel.org,
	rogerq@...nel.org,
	simona@...ll.ch,
	thierry.reding@...il.com,
	tony@...mide.com,
	tzimmermann@...e.de
Subject: Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

> We had the discussion. This should be done via pinctrl irq if possible instead of
> specifying WAKEUP_EN here, You had some trouble to understand how it can be done,
> and we agreed to add the wakeup functionality as a follow-up concentrating just
> on that detail and for now just remove WAKEUP_EN.

I think I may have understood what is to be done.
For example we have 
pinctrl-single,pins = <
	OMAP4_IOPAD(0x0bc, WAKEUP_EN | PIN_INPUT | MUX_MODE3)
>;

for wlan_host_wake, so the change needed to be done is from
interrupt-parent = <&gpio3>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "host-wake";
pinctrl-names = "default";
pinctrl-0 = <&wlan_host_wake>;

to

interrupts-extended = <&gpio3 17 IRQ_TYPE_LEVEL_HIGH>, 
			<&omap4_pmx_core 0x0bc>;
interrupt-names = "host-wake", "wakeup";

and remove the pinctrl?
Similarly for all in the omap4_pmx_core domain (wifi, bt, i2c as the
drivers support it)
No chnages for &omap4_pmx_wkup domain