linux-kernel - Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260204100730.0fcc6b46@kemnade.info>
Date: Wed, 4 Feb 2026 10:07:30 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Mithil Bavishi <bavishimithil@...il.com>
Cc: aaro.koskinen@....fi, airlied@...il.com, conor+dt@...nel.org,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 jernej.skrabec@...il.com, jonas@...boo.se, khilman@...libre.com,
 krzk+dt@...nel.org, laurent.pinchart@...asonboard.com,
 linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 neil.armstrong@...aro.org, rfoss@...nel.org, robh@...nel.org,
 rogerq@...nel.org, simona@...ll.ch, thierry.reding@...il.com,
 tony@...mide.com, tzimmermann@...e.de
Subject: Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common
 device tree for Samsung Galaxy Tab 2 series

On Wed,  4 Feb 2026 02:48:31 -0500
Mithil Bavishi <bavishimithil@...il.com> wrote:

> > We had the discussion. This should be done via pinctrl irq if possible instead of
> > specifying WAKEUP_EN here, You had some trouble to understand how it can be done,
> > and we agreed to add the wakeup functionality as a follow-up concentrating just
> > on that detail and for now just remove WAKEUP_EN.  
> 
> I think I may have understood what is to be done.
> For example we have 
> pinctrl-single,pins = <
> 	OMAP4_IOPAD(0x0bc, WAKEUP_EN | PIN_INPUT | MUX_MODE3)
> >;  
> 
> for wlan_host_wake, so the change needed to be done is from
> interrupt-parent = <&gpio3>;
> interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "host-wake";
> pinctrl-names = "default";
> pinctrl-0 = <&wlan_host_wake>;
>
we still need the pinctrl. Just the WAKEUP_EN flag gets managed via the
pinctrl interrupt handling.
 
> to
> \.
> interrupts-extended = <&gpio3 17 IRQ_TYPE_LEVEL_HIGH>, 
> 			<&omap4_pmx_core 0x0bc>;
<&omap4_pmx_core 0x7c>

offset is from beginning of padconf area, so from
0x4A10 0040, you can see that from.

In omap4-l4.dtsi:
omap4_pmx_core: pinmux@40 {
                                compatible = "ti,omap4-padconf",
                                             "pinctrl-single";
                                reg = <0x40 0x0196>;


The OMAP4_IOPAD macro handles the offset, so you have
different values there.

> interrupt-names = "host-wake", "wakeup";
> 
> and remove the pinctrl?

just remove the WAKEUP_EN flag from there.

> Similarly for all in the omap4_pmx_core domain (wifi, bt, i2c as the
> drivers support it)
> No chnages for &omap4_pmx_wkup domain
> 
The gpio instance in that domain is always-on anyways, so we do not need
any additional wakeup mechanism there.

Regards,
Andreas