linux-kernel - [PATCH] PM: sleep: wakeirq: remove outdated comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260204090431.84978-1-akaieurus@gmail.com>
Date: Wed,  4 Feb 2026 17:04:31 +0800
From: Wang Jiayue <akaieurus@...il.com>
To: rafael@...nel.org,
	lenb@...nel.org,
	pavel@...nel.org,
	gregkh@...uxfoundation.org,
	dakr@...nel.org
Cc: linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Wang Jiayue <akaieurus@...il.com>,
	Gui-Dong Han <hanguidong02@...il.com>
Subject: [PATCH] PM: sleep: wakeirq: remove outdated comments

Remove the stale documentations. The comments claiming that
dev_pm_*wake_irq*() helpers must be called with dev->power.lock held and
only from rpm_suspend/resume paths are no longer correct, since
pm_runtime_force_suspend/resume() call them lockless.

Reported-by: Gui-Dong Han <hanguidong02@...il.com>
Closes: https://lore.kernel.org/all/CAJZ5v0jN9fU9NdWqc-+F5hiSEP4JkR=_qcdGzzHtk1i5tvCDbQ@mail.gmail.com/
Fixes: c46a0d5ae4f9 ("PM: runtime: Extend support for wakeirq for force_suspend|resume")
Signed-off-by: Wang Jiayue <akaieurus@...il.com>
---
 drivers/base/power/wakeirq.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
index 8aa28c08b289..4f57058f2148 100644
--- a/drivers/base/power/wakeirq.c
+++ b/drivers/base/power/wakeirq.c
@@ -269,9 +269,6 @@ EXPORT_SYMBOL_GPL(dev_pm_set_dedicated_wake_irq_reverse);
  * starts in RPM_SUSPENDED state, and the first pm_runtime_get() would
  * otherwise try to disable already disabled wakeirq. The wake-up interrupt
  * starts disabled with IRQ_NOAUTOEN set.
- *
- * Should be only called from rpm_suspend() and rpm_resume() path.
- * Caller must hold &dev->power.lock to change wirq->status
  */
 void dev_pm_enable_wake_irq_check(struct device *dev,
 				  bool can_change_status)
@@ -303,7 +300,6 @@ void dev_pm_enable_wake_irq_check(struct device *dev,
  * @cond_disable: if set, also check WAKE_IRQ_DEDICATED_REVERSE
  *
  * Disables wake-up interrupt conditionally based on status.
- * Should be only called from rpm_suspend() and rpm_resume() path.
  */
 void dev_pm_disable_wake_irq_check(struct device *dev, bool cond_disable)
 {
@@ -328,8 +324,6 @@ void dev_pm_disable_wake_irq_check(struct device *dev, bool cond_disable)
  * Enable wake IRQ conditionally based on status, mainly used if want to
  * enable wake IRQ after running ->runtime_suspend() which depends on
  * WAKE_IRQ_DEDICATED_REVERSE.
- *
- * Should be only called from rpm_suspend() path.
  */
 void dev_pm_enable_wake_irq_complete(struct device *dev)
 {
-- 
2.34.1