linux-kernel - Re: [PATCH v2] fs: hugetlb: simplify remove_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260205011330.68096-1-sj@kernel.org>
Date: Wed,  4 Feb 2026 17:13:29 -0800
From: SeongJae Park <sj@...nel.org>
To: Jiaqi Yan <jiaqiyan@...gle.com>
Cc: SeongJae Park <sj@...nel.org>,
	jane.chu@...cle.com,
	muchun.song@...ux.dev,
	david@...nel.org,
	akpm@...ux-foundation.org,
	osalvador@...e.de,
	william.roche@...cle.com,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type

On Wed,  4 Feb 2026 21:47:41 +0000 Jiaqi Yan <jiaqiyan@...gle.com> wrote:

> When remove_inode_hugepages is introduced in
> commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove single file folio")

Why don't you wrap the above line for the 75 columns limit [1]?

> it used to return a boolean to indicate if it bailed out due to race with
> page faults. However, since the race is already solved by [1],
> remove_inode_hugepages() doesn't have any path to return false anymore.
> 
> Simplify remove_inode_hugepages() return type to void, remove the
> unnecessary ret variable, and adjust the call site in
> remove_inode_hugepages(). No functional change in this commit.
> 
> Changelog
> =========
> 
> v2 -> v1 [2]
> 
> - Use two-tab alignment for parameters wrapped to new lines.
> 
> - Remove return type in remove_inode_hugepages()'s comment.
> 
> [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com
> [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@google.com

I found David and Andrew replied the changelog will be removed in the final
one, so will not add comment.

> 
> Suggested-by: Jane Chu <jane.chu@...cle.com>
> Reviewed-by: Jane Chu <jane.chu@...cle.com>
> Reviewed-by: Muchun Song <muchun.song@...ux.dev>
> Acked-by: David Hildenbrand (arm) <david@...nel.org>
> Signed-off-by: Jiaqi Yan <jiaqiyan@...gle.com>

The above comment is only trivial, and the diff looks good to me.  So,

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]