linux-kernel - Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOPX744QCxpXZuVDfSHkw44SGe+Pr=gXt=MetcK22C7aVrv5hQ@mail.gmail.com>
Date: Thu, 5 Feb 2026 10:56:13 +0300
From: Artem Shimko <a.shimko.dev@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: p.zabel@...gutronix.de, mika.westerberg@...ux.intel.com, 
	andriy.shevchenko@...ux.intel.com, jsd@...ihalf.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control

Hi Andi,

Thank you for your review!

On Wed, Feb 4, 2026 at 4:43 AM Andi Shyti <andi.shyti@...nel.org> wrote:
> the dev_err_probe() changes are not mentioned in the commit log.
> Can you please split this patch in two, one for the
> devm_reset_control and one for the dev_err_probe?

May I suggest to keep the commit as it is? From my point of view this
dev_err_probe() relates to changes of the reset. Otherwise, I'll have
to return the reset_control_assert() to the first commit, that's
unnecessary when we use the
devm_reset_control_get_optional_exclusive_deasserted().

It'll look like:
1. devm_reset_control_get_optional_exclusive()  +
reset_control_deassert() to
devm_reset_control_get_optional_exclusive_deasserted() keeping at the
same time unnecessary reset_control_assert()
2. removing reset_control_assert()
3. cleanup of exit_probe

My suggestion:
1. change devm_reset_control_get_optional_exclusive()  +
reset_control_deassert() to
devm_reset_control_get_optional_exclusive_deasserted() as well as
remove unneeded reset_control_assert()
2. cleanup of exit_probe

Regards,
Artem