linux-kernel - Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYRwJKdaleP6R6Qe@zenone.zhora.eu>
Date: Thu, 5 Feb 2026 11:27:02 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Artem Shimko <a.shimko.dev@...il.com>
Cc: p.zabel@...gutronix.de, mika.westerberg@...ux.intel.com, 
	andriy.shevchenko@...ux.intel.com, jsd@...ihalf.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control

On Thu, Feb 05, 2026 at 10:56:13AM +0300, Artem Shimko wrote:
> Hi Andi,
> 
> Thank you for your review!
> 
> On Wed, Feb 4, 2026 at 4:43 AM Andi Shyti <andi.shyti@...nel.org> wrote:
> > the dev_err_probe() changes are not mentioned in the commit log.
> > Can you please split this patch in two, one for the
> > devm_reset_control and one for the dev_err_probe?
> 
> May I suggest to keep the commit as it is? From my point of view this
> dev_err_probe() relates to changes of the reset. Otherwise, I'll have
> to return the reset_control_assert() to the first commit, that's
> unnecessary when we use the
> devm_reset_control_get_optional_exclusive_deasserted().

I'm sorry, it looked to me in a second look like there was one
dev_err_probe() replacement independent from the patch. The patch
is fine and I'm going to apply it in i2c/i2c-host-2 (it will be
sent as a pull request next week).

Thanks,
Andi