linux-kernel - Re: [PATCH 1/2] dt-bindings: input: add GPIO charlieplex keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYRg2vP4Lfqm61qH@google.com>
Date: Thu, 5 Feb 2026 01:24:05 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: hvilleneuve@...onoff.com, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-input@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: add GPIO charlieplex keypad

Hi Hugo,

On Tue, Feb 03, 2026 at 10:49:47AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> Add DT bindings for GPIO charlieplex keypad.
> 

...

> +  linux,no-autorepeat:
> +    type: boolean
> +    description: Do not enable autorepeat feature.

Let's use standard "autorepeat" property to enable autorepeat when
needed.

> +
> +  gpio-activelow:
> +    type: boolean
> +    description:
> +      Force GPIO polarity to active low.
> +      In the absence of this property GPIOs are treated as active high.

No, the polarity should be encoded in individual GPIOs, not via a
separate property.

Thanks.

-- 
Dmitry