linux-kernel - Re: [PATCH v2 09/13] mm: update all remaining mmap_prepare users to use vma_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260206113153.c443545459474cdef6dfd7ea@linux-foundation.org>
Date: Fri, 6 Feb 2026 11:31:53 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Pedro Falcato <pfalcato@...e.de>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Jarkko Sakkinen
 <jarkko@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Thomas
 Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
 <bp@...en8.de>, x86@...nel.org, "H . Peter Anvin" <hpa@...or.com>, Arnd
 Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Dan Williams <dan.j.williams@...el.com>, Vishal Verma
 <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Jani Nikula
 <jani.nikula@...ux.intel.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Tvrtko Ursulin <tursulin@...ulin.net>, Christian Koenig
 <christian.koenig@....com>, Huang Rui <ray.huang@....com>, Matthew Auld
 <matthew.auld@...el.com>, Matthew Brost <matthew.brost@...el.com>,
 Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner
 <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Benjamin LaHaise
 <bcrl@...ck.org>, Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
 Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>,
 Sandeep Dhavale <dhavale@...gle.com>, Hongbo Li <lihongbo22@...wei.com>,
 Chunhai Guo <guochunhai@...o.com>, Theodore Ts'o <tytso@....edu>, Andreas
 Dilger <adilger.kernel@...ger.ca>, Muchun Song <muchun.song@...ux.dev>,
 Oscar Salvador <osalvador@...e.de>, David Hildenbrand <david@...nel.org>,
 Konstantin Komarov <almaz.alexandrovich@...agon-software.com>, Mike
 Marshall <hubcap@...ibond.com>, Martin Brandenburg <martin@...ibond.com>,
 Tony Luck <tony.luck@...el.com>, Reinette Chatre
 <reinette.chatre@...el.com>, Dave Martin <Dave.Martin@....com>, James Morse
 <james.morse@....com>, Babu Moger <babu.moger@....com>, Carlos Maiolino
 <cem@...nel.org>, Damien Le Moal <dlemoal@...nel.org>, Naohiro Aota
 <naohiro.aota@....com>, Johannes Thumshirn <jth@...nel.org>, Matthew Wilcox
 <willy@...radead.org>, "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>, Suren
 Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>, Hugh
 Dickins <hughd@...gle.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Zi
 Yan <ziy@...dia.com>, Nico Pache <npache@...hat.com>, Ryan Roberts
 <ryan.roberts@....com>, Dev Jain <dev.jain@....com>, Barry Song
 <baohua@...nel.org>, Lance Yang <lance.yang@...ux.dev>, Jann Horn
 <jannh@...gle.com>, David Howells <dhowells@...hat.com>, Paul Moore
 <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, "Serge E . Hallyn"
 <serge@...lyn.com>, Yury Norov <yury.norov@...il.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, linux-sgx@...r.kernel.org,
 linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev,
 linux-cxl@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, linux-fsdevel@...r.kernel.org,
 linux-aio@...ck.org, linux-erofs@...ts.ozlabs.org,
 linux-ext4@...r.kernel.org, linux-mm@...ck.org, ntfs3@...ts.linux.dev,
 devel@...ts.orangefs.org, linux-xfs@...r.kernel.org,
 keyrings@...r.kernel.org, linux-security-module@...r.kernel.org, Jason
 Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v2 09/13] mm: update all remaining mmap_prepare users to
 use vma_flags_t

On Fri, 6 Feb 2026 17:46:36 +0000 Pedro Falcato <pfalcato@...e.de> wrote:

> > -#define VM_REMAP_FLAGS (VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP)
> > +#define VMA_REMAP_FLAGS mk_vma_flags(VMA_IO_BIT, VMA_PFNMAP_BIT,	\
> > +				     VMA_DONTEXPAND_BIT, VMA_DONTDUMP_BIT)
> 
> as a sidenote, these flags are no longer constant expressions and thus
> 
> static vma_flags_t flags = VMA_REMAP_FLAGS;
> 
> can't compile.

Yup, that isn't nice.  An all-caps thing with no () is a compile-time
constant.

It looks like we can make this a nice inlined (commented!) lower-cased
C function as a little low-priority cleanup.

> Rest LGTM though.
> 
> Acked-by: Pedro Falcato <pfalcato@...e.de>

Great, thanks.