linux-kernel - RE: [PATCH v3 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <TY3PR01MB113465DF3134440209DFD94058667A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sat, 7 Feb 2026 11:19:55 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, biju.das.au <biju.das.au@...il.com>
CC: Thomas Gleixner <tglx@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>, magnus.damm
	<magnus.damm@...il.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v3 1/9] dt-bindings: interrupt-controller:
 renesas,rzg2l-irqc: Use pattern for interrupt-names

Hi Krzysztof Kozlowski,

Thanks for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 07 February 2026 10:34
> Subject: Re: [PATCH v3 1/9] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Use pattern for
> interrupt-names
> 
> On Fri, Feb 06, 2026 at 11:16:44AM +0000, Biju wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > Simplify the bindings by using pattern property for interrupt-names.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > ---
> > v2->v3:
> >  * No change
> > v1->v2:
> >  * New patch.
> > ---
> >  .../renesas,rzg2l-irqc.yaml                   | 120 ++++--------------
> >  1 file changed, 23 insertions(+), 97 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml
> > b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml index 44b6ae5fc802..a0b57d808639 100644
> > ---
> > a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l
> > -irqc.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,r
> > +++ zg2l-irqc.yaml
> > @@ -48,107 +48,33 @@ properties:
> >
> >    interrupts:
> >      minItems: 45
> > -    items:
> > -      - description: NMI interrupt
> > -      - description: IRQ0 interrupt
> 
> I do not understand how this is related to simplifying interrupt-names.

The list keeps growing, this change simplifies for RZ/G3L SoC that has 61 interrupts.
and it is not something new in bindings see [1]

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/net/snps,dwmac.yaml?h=next-20260205#n125


> 
> > -      - description: IRQ1 interrupt
> > -      - description: IRQ2 interrupt
> > -      - description: IRQ3 interrupt
> > -      - description: IRQ4 interrupt
> > -      - description: IRQ5 interrupt
> > -      - description: IRQ6 interrupt
> > -      - description: IRQ7 interrupt
> > -      - description: GPIO interrupt, TINT0
> > -      - description: GPIO interrupt, TINT1
> > -      - description: GPIO interrupt, TINT2
> > -      - description: GPIO interrupt, TINT3
> > -      - description: GPIO interrupt, TINT4
> > -      - description: GPIO interrupt, TINT5
> > -      - description: GPIO interrupt, TINT6
> > -      - description: GPIO interrupt, TINT7
> > -      - description: GPIO interrupt, TINT8
> > -      - description: GPIO interrupt, TINT9
> > -      - description: GPIO interrupt, TINT10
> > -      - description: GPIO interrupt, TINT11
> > -      - description: GPIO interrupt, TINT12
> > -      - description: GPIO interrupt, TINT13
> > -      - description: GPIO interrupt, TINT14
> > -      - description: GPIO interrupt, TINT15
> > -      - description: GPIO interrupt, TINT16
> > -      - description: GPIO interrupt, TINT17
> > -      - description: GPIO interrupt, TINT18
> > -      - description: GPIO interrupt, TINT19
> > -      - description: GPIO interrupt, TINT20
> > -      - description: GPIO interrupt, TINT21
> > -      - description: GPIO interrupt, TINT22
> > -      - description: GPIO interrupt, TINT23
> > -      - description: GPIO interrupt, TINT24
> > -      - description: GPIO interrupt, TINT25
> > -      - description: GPIO interrupt, TINT26
> > -      - description: GPIO interrupt, TINT27
> > -      - description: GPIO interrupt, TINT28
> > -      - description: GPIO interrupt, TINT29
> > -      - description: GPIO interrupt, TINT30
> > -      - description: GPIO interrupt, TINT31
> > -      - description: Bus error interrupt
> > -      - description: ECCRAM0 or combined ECCRAM0/1 1bit error interrupt
> > -      - description: ECCRAM0 or combined ECCRAM0/1 2bit error interrupt
> > -      - description: ECCRAM0 or combined ECCRAM0/1 error overflow interrupt
> > -      - description: ECCRAM1 1bit error interrupt
> > -      - description: ECCRAM1 2bit error interrupt
> > -      - description: ECCRAM1 error overflow interrupt
> > +    maxItems: 48
> >
> >    interrupt-names:
> >      minItems: 45
> > +    maxItems: 48
> >      items:
> > -      - const: nmi
> > -      - const: irq0
> > -      - const: irq1
> > -      - const: irq2
> > -      - const: irq3
> > -      - const: irq4
> > -      - const: irq5
> > -      - const: irq6
> > -      - const: irq7
> > -      - const: tint0
> > -      - const: tint1
> > -      - const: tint2
> > -      - const: tint3
> > -      - const: tint4
> > -      - const: tint5
> > -      - const: tint6
> > -      - const: tint7
> > -      - const: tint8
> > -      - const: tint9
> > -      - const: tint10
> > -      - const: tint11
> > -      - const: tint12
> > -      - const: tint13
> > -      - const: tint14
> > -      - const: tint15
> > -      - const: tint16
> > -      - const: tint17
> > -      - const: tint18
> > -      - const: tint19
> > -      - const: tint20
> > -      - const: tint21
> > -      - const: tint22
> > -      - const: tint23
> > -      - const: tint24
> > -      - const: tint25
> > -      - const: tint26
> > -      - const: tint27
> > -      - const: tint28
> > -      - const: tint29
> > -      - const: tint30
> > -      - const: tint31
> > -      - const: bus-err
> > -      - const: ec7tie1-0
> > -      - const: ec7tie2-0
> > -      - const: ec7tiovf-0
> > -      - const: ec7tie1-1
> > -      - const: ec7tie2-1
> > -      - const: ec7tiovf-1
> > +      oneOf:
> > +        - description: NMI interrupt
> > +          const: nmi
> 
> Your commit msg is completely inaccurate. You are not simplifying, you are CHANGING by allowing any
> order.

You are correct, apart from keep adding more interrupts in description and items,
it allows to change by any order based on the pattern.

Cheers,
Biju