linux-kernel - Re: [PATCH] staging: most: dim2: convert pr_info/err/warn to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020739-oat-tinker-84a6@gregkh>
Date: Sat, 7 Feb 2026 12:54:32 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
Cc: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
	Christian Gromm <christian.gromm@...rochip.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: most: dim2: convert pr_info/err/warn to
 dev_info/err/warn

On Fri, Feb 06, 2026 at 12:13:14AM +0500, Zeeshan Ahmad wrote:
> The dim2 driver currently uses generic pr_* logging macros. Hardware
> drivers should use the device-specific dev_* logging macros to provide
> better context in the system logs, especially in systems with multiple
> controller instances.
> 
> This patch converts all applicable logging calls in dim2.c to use the
> proper device-specific APIs.
> 
> Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
> ---
>  drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++----------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index dad2abe6c0c9..e6d99d9009b5 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -244,9 +244,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo)
>  {
>  	u8 *data = mbo->virt_address;
>  
> -	pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
> +	dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
>  	dev->link_state = data[18];
> -	pr_info("NIState: %d\n", dev->link_state);
> +	dev_info(&dev->dev, "NIState: %d\n", dev->link_state);

This is a nice start, but when drivers work properly, they should be
quiet.  Can you make this a 2 patch series, the first getting rid of
these "extra" messages (or moving them to dev_dbg()) and the second
doing the other conversions?

thanks,

greg k-h