lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2026020731-zipping-keenly-ae34@gregkh>
Date: Sat, 7 Feb 2026 14:11:58 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: dan.carpenter@...aro.org, straube.linux@...il.com, hansg@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/4] staging: rtl8723bs: rename LinkDetectInfo and
 clean up related code

On Sun, Feb 01, 2026 at 05:08:34PM +0530, Khushal Chitturi wrote:
> This patch renames LinkDetectInfo instance to link_detect_info and update
> the fields of rt_link_detect_t to follow kernel naming conventions.
> Local variables in traffic_status_watchdog were also updated for
> consistency.

Please only do one logical thing per patch.  This is way too many
renames to try to verify you got it all correct here, would you like to
have to review this?  :)

> Signed-off-by: Khushal Chitturi <khushalchitturi@...il.com>
> 
> ---

No need for a blank line after your signed-off-by line.

> Changelog:
> v5 -> v6: Limited the changes to LinkDetectInfo renaming.

No, you also changed the local variables.  Don't make fake claims in
changelog versions :(

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ