linux-kernel - Re: [PATCH v6 3/4] staging: rtl8723bs: simplify boolean expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020744-dweeb-wimp-dba0@gregkh>
Date: Sat, 7 Feb 2026 14:13:05 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: dan.carpenter@...aro.org, straube.linux@...il.com, hansg@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/4] staging: rtl8723bs: simplify boolean expressions

On Sun, Feb 01, 2026 at 05:08:36PM +0530, Khushal Chitturi wrote:
> Simplify boolean expressions across rtl8723bs to comply
> with the kernel coding style.
> 
> Signed-off-by: Khushal Chitturi <khushalchitturi@...il.com>
> 
> ---
> Changelog:
> v5 -> v6: Extend boolean simplification to ioctl_cfg80211.c and
> rtw_ioctl_set.c
> v4 -> v5: Rebased onto current staging-testing.
> v3 -> v4: Fixed alignment and removed extra parentheses.
> v2 -> v3: Resubmitted as a versioned series to avoid threading confusion.
> v1 -> v2: Corrected commit messages.
> 
>  .../staging/rtl8723bs/core/rtw_ioctl_set.c    | 63 +++++++++----------
>  drivers/staging/rtl8723bs/core/rtw_xmit.c     | 40 ++++++------
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 14 ++---
>  3 files changed, 58 insertions(+), 59 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index 2d37ac4c50ef..dab20b8a9b18 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -61,14 +61,11 @@ u8 rtw_do_join(struct adapter *padapter)
>  		/* when set_ssid/set_bssid for rtw_do_join(), but scanning queue is empty */
>  		/* we try to issue sitesurvey firstly */
>  
> -		if (pmlmepriv->link_detect_info.busy_traffic == false
> -			|| rtw_to_roam(padapter) > 0
> -		) {
> +		if (!pmlmepriv->link_detect_info.busy_traffic || rtw_to_roam(padapter) > 0) {
>  			/*  submit site_survey_cmd */
>  			ret = rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL, 0);
>  			if (ret != _SUCCESS)
>  				pmlmepriv->to_join = false;
> -
>  		} else {

You also removed blank lines without mentioning it :(

Again, please only do one logical thing per change.

thanks,

greg k-h