linux-kernel - Re: [PATCH] staging: nvec: use strcmp() instead of strncmp() with magic length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020754-finalist-unbent-f4fd@gregkh>
Date: Sat, 7 Feb 2026 14:41:33 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Artem Lytkin <iprintercanon@...il.com>
Cc: Marc Dietrich <marvin24@....de>, ac100@...ts.launchpad.net,
	linux-tegra@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: nvec: use strcmp() instead of strncmp() with
 magic length

On Thu, Feb 05, 2026 at 11:46:32PM +0000, Artem Lytkin wrote:
> Replace strncmp() with a hardcoded length of 30 with strcmp().
> The bat_type string is already null-terminated (set two lines above),
> so strncmp() with an arbitrary length is misleading and functionally
> equivalent to strcmp().
> 
> Signed-off-by: Artem Lytkin <iprintercanon@...il.com>
> ---
>  drivers/staging/nvec/nvec_power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c
> index 2faab9fde..89dd997aa 100644
> --- a/drivers/staging/nvec/nvec_power.c
> +++ b/drivers/staging/nvec/nvec_power.c
> @@ -207,7 +207,7 @@ static int nvec_power_bat_notifier(struct notifier_block *nb,
>  		 * This differs a little from the spec fill in more if you find
>  		 * some.
>  		 */
> -		if (!strncmp(power->bat_type, "Li", 30))
> +		if (!strcmp(power->bat_type, "Li"))

Now the checking tools that look for "strcmp() is bad!" will come along
and someone will send a patch that essencially reverts this :)

Please just leave this as-is, it's really fine and is not broken, right?

thanks,

greg k-h