linux-kernel - Re: [PATCH] staging: rtl8723bs: rename camelCase variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020733-blatancy-periscope-e425@gregkh>
Date: Sat, 7 Feb 2026 14:43:16 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Nikolay Kulikov <nikolayof23@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename camelCase variables

On Fri, Feb 06, 2026 at 03:25:53PM +0300, Nikolay Kulikov wrote:
> Rename "pHT_caps_ie" to "pht_caps_ie" and "pHT_info_ie" to "pht_info_ie"
> local variables to comply with Linux coding style.

Why did you pick these names?  You kept the "p" prefix for some reason,
which is "Hungarian" notation, and is not a kernel coding style, so
shouldn't you just use a name that reflects what this variable is doing,
and not encode the type in it?

thanks,

greg k-h